path: root/contrib
diff options
authorElia Pinto <>2015-12-22 14:10:28 (GMT)
committerJunio C Hamano <>2015-12-27 23:33:13 (GMT)
commit57eb1bef7d86507437ebdfa5a855508e6ab05035 (patch)
treeab0ad06302eed4ed6bd6d26c3d4986b1bc5171a1 /contrib
parentbc32bacc72078b92b9e9f02acec63ccc28564a01 (diff)
contrib/thunderbird-patch-inline/ use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}" done and then carefully proof-read. Signed-off-by: Elia Pinto <> Reviewed-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib')
1 files changed, 2 insertions, 2 deletions
diff --git a/contrib/thunderbird-patch-inline/ b/contrib/thunderbird-patch-inline/
index 8dc73ec..1053872 100755
--- a/contrib/thunderbird-patch-inline/
+++ b/contrib/thunderbird-patch-inline/
@@ -31,8 +31,8 @@ BODY=$(sed -e "1,/${SEP}/d" $1)
CMT_MSG=$(sed -e '1,/^$/d' -e '/^---$/,$d' "${PATCH}")
DIFF=$(sed -e '1,/^---$/d' "${PATCH}")
-CCS=`echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
- -e 's/^Signed-off-by: \(.*\)/\1,/gp'`
+CCS=$(echo -e "$CMT_MSG\n$HEADERS" | sed -n -e 's/^Cc: \(.*\)$/\1,/gp' \
+ -e 's/^Signed-off-by: \(.*\)/\1,/gp')
echo "$SUBJECT" > $1
echo "Cc: $CCS" >> $1