summaryrefslogtreecommitdiff
path: root/contrib
diff options
context:
space:
mode:
authorRobert Estelle <robertestelle@gmail.com>2021-10-25 22:29:33 (GMT)
committerJunio C Hamano <gitster@pobox.com>2021-10-28 16:33:19 (GMT)
commit46b05852863a532a897f09a8461586f3d2d38693 (patch)
treeaeb8b6db6bec503b46f3282ad90a1844b84dda48 /contrib
parentaf6d1d602a8f64164b266364339c4e936d5bbc33 (diff)
downloadgit-46b05852863a532a897f09a8461586f3d2d38693.zip
git-46b05852863a532a897f09a8461586f3d2d38693.tar.gz
git-46b05852863a532a897f09a8461586f3d2d38693.tar.bz2
completion: fix incorrect bash/zsh string equality check
In the basic `[`/`test` command, the string equality operator is a single `=`. The `==` operator is only available in `[[`, which is a bash-ism also supported by zsh. This mix-up was causing the following completion error in zsh: > __git_ls_files_helper:7: = not found (That message refers to the extraneous symbol in `==` ← `=`). This updates that comparison to use a single `=` inside the basic `[ … ]` test conditional. Although this fix is inconsistent with the other comparisons in this file, which use `[[ … == … ]]`, and the two expressions are functionally identical in this context, that approach was rejected due to a preference for `[`. Signed-off-by: Robert Estelle <robertestelle@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
-rw-r--r--contrib/completion/git-completion.bash2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 8108eda..0a20fa5 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -515,7 +515,7 @@ __gitcomp_file ()
# argument, and using the options specified in the second argument.
__git_ls_files_helper ()
{
- if [ "$2" == "--committable" ]; then
+ if [ "$2" = "--committable" ]; then
__git -C "$1" -c core.quotePath=false diff-index \
--name-only --relative HEAD -- "${3//\\/\\\\}*"
else