path: root/contrib
diff options
authorJohn Szakmeister <>2014-11-04 20:01:12 (GMT)
committerJunio C Hamano <>2014-11-04 21:18:35 (GMT)
commit251e7dad517bd369387c4dedfe77b380f025e0f3 (patch)
treeb7ba495d93e721ac136eac5a5f421b7460e2981c /contrib
parenteeff891ac756fd97a05476446f15269b714ce4cc (diff)
diff-highlight: exit when a pipe is broken
While using diff-highlight with other tools, I have discovered that Python ignores SIGPIPE by default. Unfortunately, this also means that tools attempting to launch a pager under Python--and don't realize this is happening--means that the subprocess inherits this setting. In this case, it means diff-highlight will be launched with SIGPIPE being ignored. Let's work with those broken scripts by restoring the default SIGPIPE handler. Signed-off-by: John Szakmeister <> Acked-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib')
1 files changed, 4 insertions, 0 deletions
diff --git a/contrib/diff-highlight/diff-highlight b/contrib/diff-highlight/diff-highlight
index c4404d4..69a652e 100755
--- a/contrib/diff-highlight/diff-highlight
+++ b/contrib/diff-highlight/diff-highlight
@@ -14,6 +14,10 @@ my @removed;
my @added;
my $in_hunk;
+# Some scripts may not realize that SIGPIPE is being ignored when launching the
+# pager--for instance scripts written in Python.
while (<>) {
if (!$in_hunk) {