path: root/contrib/mw-to-git
diff options
authorCélestin Matte <>2013-06-14 13:50:37 (GMT)
committerJunio C Hamano <>2013-06-14 16:02:18 (GMT)
commitb5cda5b3132a56e87caad5d8a541f09733f1ed33 (patch)
tree394bdeca39aac5ebec20c95180527f1818e8ccce /contrib/mw-to-git
parentd49a038451e86a207eee6b8f0fb2a022410900cc (diff)
git-remote-mediawiki: add a .perlcriticrc file
Such a file allows to configure perlcritic. Here, it is used to remove many unwanted rules and configure one to remove unwanted warnings. Signed-off-by: Célestin Matte <> Signed-off-by: Matthieu Moy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib/mw-to-git')
1 files changed, 28 insertions, 0 deletions
diff --git a/contrib/mw-to-git/.perlcriticrc b/contrib/mw-to-git/.perlcriticrc
new file mode 100644
index 0000000..5a9955d
--- /dev/null
+++ b/contrib/mw-to-git/.perlcriticrc
@@ -0,0 +1,28 @@
+# These 3 rules demand to add the s, m and x flag to *every* regexp. This is
+# overkill and would be harmful for readability.
+# This rule says that builtin functions should not be called with parentheses
+# e.g.: (taken from CPAN's documentation)
+# open($handle, '>', $filename); #not ok
+# open $handle, '>', $filename; #ok
+# Applying such a rule would mean modifying a huge number of lines for a
+# question of style.
+# This rule states that each system call should have its return value checked
+# The problem is that it includes the print call. Checking every print call's
+# return value would be harmful to the code readabilty.
+# This configuration keeps all default function but print.
+functions = open say close
+# This rules demands to add a dependancy for the Readonly module. This is not
+# wished.
+# This rule is not really useful (rather a question of style) and produces many
+# warnings among the code.