path: root/contrib/mw-to-git
diff options
authorElia Pinto <>2014-04-23 13:43:53 (GMT)
committerJunio C Hamano <>2014-04-23 22:17:01 (GMT)
commit9bfeaa0bcf2d7150836b583196e18f973c3be17f (patch)
tree3f610009b1cd9345d1173eb454cd8d75d1bad65b /contrib/mw-to-git
parentbd368a9baf5a42e2076ef4c8a35312ccab171452 (diff)
git-9bfeaa0bcf2d7150836b583196e18f973c3be17f.tar.bz2 use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <> Reviewed-by: Matthieu Moy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib/mw-to-git')
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/mw-to-git/t/ b/contrib/mw-to-git/t/
index 27e267f..0164547 100755
--- a/contrib/mw-to-git/t/
+++ b/contrib/mw-to-git/t/
@@ -9,7 +9,7 @@ test_check_precond
test_expect_success 'creating page w/ >500 revisions' '
wiki_reset &&
- for i in `test_seq 501`
+ for i in $(test_seq 501)
echo "creating revision $i" &&
wiki_editpage foo "revision $i<br/>" true