path: root/contrib/mw-to-git
diff options
authorCélestin Matte <>2013-06-14 13:50:17 (GMT)
committerJunio C Hamano <>2013-06-14 16:02:16 (GMT)
commit1149957368ef29b6a05ad5cf93f6c62352136bcd (patch)
treea7a6a107ca1f4769860d520d6a56667e3e4083f6 /contrib/mw-to-git
parenteb96b750394a78d9317f0a9224689f1ef50f04ec (diff)
git-remote-mediawiki: change the behaviour of a split
A "split ' '" is turned into a "split / /", which changes its behaviour: the old method matched a run of whitespaces (/\s*/), while the new one will match a single space, which is what we want here. Indeed, in other contexts, changing split(' ') to split(/ /) could potentially be a regression, however, here, when parsing the output of "rev-list --parents", whose output SHA-1's are each separated by a single space, splitting on a single space is perfectly correct. Signed-off-by: Célestin Matte <> Signed-off-by: Matthieu Moy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'contrib/mw-to-git')
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/mw-to-git/git-remote-mediawiki.perl b/contrib/mw-to-git/git-remote-mediawiki.perl
index b65e71c..74344f6 100755
--- a/contrib/mw-to-git/git-remote-mediawiki.perl
+++ b/contrib/mw-to-git/git-remote-mediawiki.perl
@@ -1168,7 +1168,7 @@ sub mw_push_revision {
my %local_ancestry;
foreach my $line (@local_ancestry) {
if (my ($child, $parents) = $line =~ /^-?([a-f0-9]+) ([a-f0-9 ]+)/) {
- foreach my $parent (split(' ', $parents)) {
+ foreach my $parent (split(/ /, $parents)) {
$local_ancestry{$parent} = $child;
} elsif (!$line =~ /^([a-f0-9]+)/) {