summaryrefslogtreecommitdiff
path: root/contrib/examples/git-revert.sh
diff options
context:
space:
mode:
authorElia Pinto <gitter.spiros@gmail.com>2014-04-16 17:29:55 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-04-17 18:15:00 (GMT)
commitfb6644a32fa06ff2698ecc66f4008d2afdf0b9c7 (patch)
tree136e471dafac95412486e0dc5fdc68e0293506da /contrib/examples/git-revert.sh
parent6aeb30eb9fb59f97dd59cc0b580f95a0b98bbe48 (diff)
downloadgit-fb6644a32fa06ff2698ecc66f4008d2afdf0b9c7.zip
git-fb6644a32fa06ff2698ecc66f4008d2afdf0b9c7.tar.gz
git-fb6644a32fa06ff2698ecc66f4008d2afdf0b9c7.tar.bz2
git-revert.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command substitution instead of using the backquotes `...`. The backquoted form is the traditional method for command substitution, and is supported by POSIX. However, all but the simplest uses become complicated quickly. In particular, embedded command substitutions and/or the use of double quotes require careful escaping with the backslash character. The patch was generated by: for _f in $(find . -name "*.sh") do sed -i 's@`\(.*\)`@$(\1)@g' ${_f} done and then carefully proof-read. Signed-off-by: Elia Pinto <gitter.spiros@gmail.com> Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/examples/git-revert.sh')
-rwxr-xr-xcontrib/examples/git-revert.sh2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/examples/git-revert.sh b/contrib/examples/git-revert.sh
index 6bf155c..7e2aad5 100755
--- a/contrib/examples/git-revert.sh
+++ b/contrib/examples/git-revert.sh
@@ -137,7 +137,7 @@ cherry-pick)
q
}'
- logmsg=`git show -s --pretty=raw --encoding="$encoding" "$commit"`
+ logmsg=$(git show -s --pretty=raw --encoding="$encoding" "$commit")
set_author_env=`echo "$logmsg" |
LANG=C LC_ALL=C sed -ne "$pick_author_script"`
eval "$set_author_env"