summaryrefslogtreecommitdiff
path: root/contrib/completion/git-completion.bash
diff options
context:
space:
mode:
authorChristian Couder <christian.couder@gmail.com>2019-05-29 12:44:32 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-05-29 18:05:34 (GMT)
commite693237e2ba27b6129e8af7f6a794f5c2fbd26f3 (patch)
tree2317223e6228a03a1b0b9fd4ecf5dc51a5eb5fbb /contrib/completion/git-completion.bash
parentaa25c82427ae70aebf3b8f970f2afd54e9a2a8c6 (diff)
downloadgit-e693237e2ba27b6129e8af7f6a794f5c2fbd26f3.zip
git-e693237e2ba27b6129e8af7f6a794f5c2fbd26f3.tar.gz
git-e693237e2ba27b6129e8af7f6a794f5c2fbd26f3.tar.bz2
list-objects-filter: disable 'sparse:path' filters
If someone wants to use as a filter a sparse file that is in the repository, something like "--filter=sparse:oid=<ref>:<path>" already works. So 'sparse:path' is only interesting if the sparse file is not in the repository. In this case though the current implementation has a big security issue, as it makes it possible to ask the server to read any file, like for example /etc/password, and to explore the filesystem, as well as individual lines of files. If someone is interested in using a sparse file that is not in the repository as a filter, then at the minimum a config option, such as "uploadpack.sparsePathFilter", should be implemented first to restrict the directory from which the files specified by 'sparse:path' can be read. For now though, let's just disable 'sparse:path' filters. Helped-by: Matthew DeVore <matvore@google.com> Helped-by: Jeff Hostetler <git@jeffhostetler.com> Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib/completion/git-completion.bash')
-rw-r--r--contrib/completion/git-completion.bash2
1 files changed, 1 insertions, 1 deletions
diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
index 3eefbab..9f71bcd 100644
--- a/contrib/completion/git-completion.bash
+++ b/contrib/completion/git-completion.bash
@@ -1536,7 +1536,7 @@ _git_fetch ()
return
;;
--filter=*)
- __gitcomp "blob:none blob:limit= sparse:oid= sparse:path=" "" "${cur##--filter=}"
+ __gitcomp "blob:none blob:limit= sparse:oid=" "" "${cur##--filter=}"
return
;;
--*)