path: root/connect.c
diff options
authorJunio C Hamano <>2007-01-22 01:10:51 (GMT)
committerJunio C Hamano <>2007-01-22 05:51:01 (GMT)
commitec587fde0a76780931c7ac32474c8c000aa45134 (patch)
tree8b1e608dd2f2641adbfe06cc4c0047ceb88c9d53 /connect.c
parent026aa93818a536c819a94aae5bbefe1b6251fe0e (diff)
Make sure git_connect() always give two file descriptors.
Earlier, git_connect() returned the same fd twice or two separate fds, depending on the way the connection was made (when we are talking to the other end over a single socket, we used the same fd twice, and when our end is connected to a pipepair we used two). This forced callers who do close() and dup() to really care which was which, and most of the existing callers got this wrong, although without much visible ill effect. Many were closing the same fd twice when we are talking over a single socket, and one was leaking a fd. This fixes it to uniformly use two separate fds, so if somebody wants to close only reader side can just do close() on it without worrying about it accidentally also closing the writer side or vice versa. Signed-off-by: Linus Torvalds <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'connect.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/connect.c b/connect.c
index 66daa11..7844888 100644
--- a/connect.c
+++ b/connect.c
@@ -529,7 +529,7 @@ static void git_tcp_connect(int fd[2], char *host)
int sockfd = git_tcp_connect_sock(host);
fd[0] = sockfd;
- fd[1] = sockfd;
+ fd[1] = dup(sockfd);