path: root/config.c
diff options
authorJim Meyering <>2009-09-12 08:54:32 (GMT)
committerJunio C Hamano <>2009-09-13 08:31:10 (GMT)
commit2b7ca830c6a6e4f0e1722e24973a026b5b867227 (patch)
treefdcc68951d8e3653cfd54e02ca1c0f1742f4c8a6 /config.c
parent511a3fc116799df5e3b2262f8f6e501ca73ba2fe (diff)
use write_str_in_full helper to avoid literal string lengths
In 2d14d65 (Use a clearer style to issue commands to remote helpers, 2009-09-03) I happened to notice two changes like this: - write_in_full(helper->in, "list\n", 5); + + strbuf_addstr(&buf, "list\n"); + write_in_full(helper->in, buf.buf, buf.len); + strbuf_reset(&buf); IMHO, it would be better to define a new function, static inline ssize_t write_str_in_full(int fd, const char *str) { return write_in_full(fd, str, strlen(str)); } and then use it like this: - strbuf_addstr(&buf, "list\n"); - write_in_full(helper->in, buf.buf, buf.len); - strbuf_reset(&buf); + write_str_in_full(helper->in, "list\n"); Thus not requiring the added allocation, and still avoiding the maintenance risk of literal string lengths. These days, compilers are good enough that strlen("literal") imposes no run-time cost. Transformed via this: perl -pi -e \ 's/write_in_full\((.*?), (".*?"), \d+\)/write_str_in_full($1, $2)/'\ $(git grep -l 'write_in_full.*"') Signed-off-by: Jim Meyering <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'config.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/config.c b/config.c
index e87edea..bf12220 100644
--- a/config.c
+++ b/config.c
@@ -1116,7 +1116,7 @@ int git_config_set_multivar(const char *key, const char *value,
copy_end - copy_begin)
goto write_err_out;
if (new_line &&
- write_in_full(fd, "\n", 1) != 1)
+ write_str_in_full(fd, "\n") != 1)
goto write_err_out;
copy_begin = store.offset[i];