summaryrefslogtreecommitdiff
path: root/compat
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2019-10-25 14:13:36 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-10-28 03:38:51 (GMT)
commit60e6569a1207d75a351684e2c48f8d18d15a0032 (patch)
treefab1f1f9aff26cdc1522c9837a51eab82815ba1f /compat
parent5fa0f5238b0cd46cfe7f6fa76c3f526ea98148d9 (diff)
downloadgit-60e6569a1207d75a351684e2c48f8d18d15a0032.zip
git-60e6569a1207d75a351684e2c48f8d18d15a0032.tar.gz
git-60e6569a1207d75a351684e2c48f8d18d15a0032.tar.bz2
mingw: avoid a buffer overrun in `needs_hiding()`
When this function is passed a path with a trailing slash, it runs right over the end of that path. Let's fix this. Co-authored-by: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat')
-rw-r--r--compat/mingw.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/compat/mingw.c b/compat/mingw.c
index 738f0a8..f76ba3d 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -363,6 +363,8 @@ static inline int needs_hiding(const char *path)
/* ignore trailing slashes */
if (*path)
basename = path;
+ else
+ break;
}
if (hide_dotfiles == HIDE_DOTFILES_TRUE)