path: root/compat
diff options
authorJunio C Hamano <>2011-06-20 19:31:59 (GMT)
committerJunio C Hamano <>2011-06-20 20:09:04 (GMT)
commit085479e7001b6feb7e9be02e77d84e27be796774 (patch)
tree79ac03db029aec24eba22a5cc050b85047537977 /compat
parentdaab4eeafa0dc620d67ccb57c28e08f6f8b3868c (diff)
cygwin: trust executable bit by default
Earlier 7974843 (compat/cygwin.c: make runtime detection of lstat/stat lessor impact, 2008-10-23) fixed the low-level "do we use cygwin specific hacks for stat/lstat?" logic not to call into git_default_config() from random codepaths that are typically very late in the program, to prevent the call from potentially overwriting other variables that are initialized from the configuration. However, it forgot that on Cygwin, trust-executable-bit should default to true. Noticed by J6t, confirmed by Ramsay Jones, and the brown paper bag is on Gitster's head. Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'compat')
1 files changed, 1 insertions, 1 deletions
diff --git a/compat/cygwin.c b/compat/cygwin.c
index b4a51b9..ba3327f 100644
--- a/compat/cygwin.c
+++ b/compat/cygwin.c
@@ -101,7 +101,7 @@ static int cygwin_stat(const char *path, struct stat *buf)
* and calling git_default_config() from here would break such variables.
static int native_stat = 1;
-static int core_filemode;
+static int core_filemode = 1; /* matches trust_executable_bit default */
static int git_cygwin_config(const char *var, const char *value, void *cb)