summaryrefslogtreecommitdiff
path: root/compat/mingw.h
diff options
context:
space:
mode:
authorJohannes Sixt <johannes.sixt@telecom.at>2007-12-07 21:05:36 (GMT)
committerJohannes Sixt <johannes.sixt@telecom.at>2008-06-23 11:40:31 (GMT)
commit897bb8cb2c2ce6b73038bd8d4106fde079a09cf6 (patch)
tree80307ea3202fd6faa95d35873945860f23e415f1 /compat/mingw.h
parentf1a4dfb85a432ae338d162179eaac5d50154fbeb (diff)
downloadgit-897bb8cb2c2ce6b73038bd8d4106fde079a09cf6.zip
git-897bb8cb2c2ce6b73038bd8d4106fde079a09cf6.tar.gz
git-897bb8cb2c2ce6b73038bd8d4106fde079a09cf6.tar.bz2
Windows: A pipe() replacement whose ends are not inherited to children.
On Unix the idiom to use a pipe is as follows: pipe(fd); pid = fork(); if (!pid) { dup2(fd[1], 1); close(fd[1]); close(fd[0]); ... } close(fd[1]); i.e. the child process closes the both pipe ends after duplicating one to the file descriptors where they are needed. On Windows, which does not have fork(), we never have an opportunity to (1) duplicate a pipe end in the child, (2) close unused pipe ends. Instead, we must use this idiom: save1 = dup(1); pipe(fd); dup2(fd[1], 1); spawn(...); dup2(save1, 1); close(fd[1]); i.e. save away the descriptor at the destination slot, replace by the pipe end, spawn process, restore the saved file. But there is a problem: Notice that the child did not only inherit the dup2()ed descriptor, but also *both* original pipe ends. Although the one end that was dup()ed could be closed before the spawn(), we cannot close the other end - the child inherits it, no matter what. The solution is to generate non-inheritable pipes. At the first glance, this looks strange: The purpose of pipes is usually to be inherited to child processes. But notice that in the course of actions as outlined above, the pipe descriptor that we want to inherit to the child is dup2()ed, and as it so happens, Windows's dup2() creates inheritable duplicates. Signed-off-by: Johannes Sixt <johannes.sixt@telecom.at>
Diffstat (limited to 'compat/mingw.h')
-rw-r--r--compat/mingw.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/compat/mingw.h b/compat/mingw.h
index 3ddef11..0ce9c96 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h
@@ -122,14 +122,11 @@ static inline int waitpid(pid_t pid, unsigned *status, unsigned options)
return -1;
}
-
-static inline int pipe(int filedes[2])
-{ return _pipe(filedes, 8192, 0); }
-
/*
* implementations of missing functions
*/
+int pipe(int filedes[2]);
unsigned int sleep (unsigned int seconds);
int mkstemp(char *template);
int gettimeofday(struct timeval *tv, void *tz);