summaryrefslogtreecommitdiff
path: root/compat/mingw.c
diff options
context:
space:
mode:
authorJohannes Schindelin <johannes.schindelin@gmx.de>2019-07-04 22:36:57 (GMT)
committerJunio C Hamano <gitster@pobox.com>2019-07-08 19:09:12 (GMT)
commit697bdd22b887a0778489814e44dcec850aa82ad0 (patch)
treed8799bdc7f1534fbb342c35edf834e6301a9f3bf /compat/mingw.c
parent94238859b9809afc806919cb7022a45cdc8e6748 (diff)
downloadgit-697bdd22b887a0778489814e44dcec850aa82ad0.zip
git-697bdd22b887a0778489814e44dcec850aa82ad0.tar.gz
git-697bdd22b887a0778489814e44dcec850aa82ad0.tar.bz2
mingw: fix possible buffer overrun when calling `GetUserNameW()`
In 39a98e9b68b8 (mingw: get pw_name in UTF-8 format, 2019-06-27), this developer missed the fact that the `GetUserNameW()` function takes the number of characters as `len` parameter, not the number of bytes. Reported-by: Beat Bolli <dev+git@drbeat.li> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat/mingw.c')
-rw-r--r--compat/mingw.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/compat/mingw.c b/compat/mingw.c
index b8a62bf..a0eb695 100644
--- a/compat/mingw.c
+++ b/compat/mingw.c
@@ -1952,7 +1952,7 @@ struct passwd *getpwuid(int uid)
if (initialized)
return p;
- len = sizeof(buf);
+ len = ARRAY_SIZE(buf);
if (!GetUserNameW(buf, &len)) {
initialized = 1;
return NULL;