path: root/commit.h
diff options
authorDenton Liu <>2019-04-29 08:28:20 (GMT)
committerJunio C Hamano <>2019-05-05 06:20:08 (GMT)
commitb199d7147a218c3b10b077f9caad0f207bc34d7a (patch)
tree56c58e8053c5f5c8d177d84f1f29ca7449c17d42 /commit.h
parent554544276a604c144df45efcb060c80aa322088c (diff)
*.[ch]: remove extern from function declarations using sed
There has been a push to remove extern from function declarations. Finish the job by removing all instances of "extern" for function declarations in headers using sed. This was done by running the following on my system with sed 4.2.2: $ git ls-files \*.{c,h} | grep -v ^compat/ | xargs sed -i'' -e 's/^\(\s*\)extern \([^(]*([^*]\)/\1\2/' Files under `compat/` are intentionally excluded as some are directly copied from external sources and we should avoid churning them as much as possible. Then, leftover instances of extern were found by running $ git grep -w -C3 extern \*.{c,h} and manually checking the output. No other instances were found. Note that the regex used specifically excludes function variables which _should_ be left as extern. Not the most elegant way to do it but it gets the job done. Signed-off-by: Denton Liu <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'commit.h')
1 files changed, 1 insertions, 1 deletions
diff --git a/commit.h b/commit.h
index 26d0b51..40744e1 100644
--- a/commit.h
+++ b/commit.h
@@ -379,6 +379,6 @@ int compare_commits_by_commit_date(const void *a_, const void *b_, void *unused)
int compare_commits_by_gen_then_commit_date(const void *a_, const void *b_, void *unused);
-extern int run_commit_hook(int editor_is_used, const char *index_file, const char *name, ...);
+int run_commit_hook(int editor_is_used, const char *index_file, const char *name, ...);
#endif /* COMMIT_H */