path: root/commit.c
diff options
authorAbhishek Kumar <>2020-06-17 09:14:10 (GMT)
committerJunio C Hamano <>2020-06-17 21:37:30 (GMT)
commitc49c82aa4c1036ba1629f73223cff53230e695f3 (patch)
tree91592f05de84792ad87abc8515662353a4fe6390 /commit.c
parent4844812b9ec9bc6ffdc2da2c54d9146ff4c97d94 (diff)
commit: move members graph_pos, generation to a slab
We remove members `graph_pos` and `generation` from the struct commit. The default assignments in init_commit_node() are no longer valid, which is fine as the slab helpers return appropriate default values and the assignments are removed. We will replace existing use of commit->generation and commit->graph_pos by commit_graph_data_slab helpers using `contrib/coccinelle/commit.cocci'. Signed-off-by: Abhishek Kumar <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'commit.c')
1 files changed, 3 insertions, 3 deletions
diff --git a/commit.c b/commit.c
index b30875e..ed0917a 100644
--- a/commit.c
+++ b/commit.c
@@ -339,7 +339,7 @@ struct tree *repo_get_commit_tree(struct repository *r,
if (commit->maybe_tree || !commit->object.parsed)
return commit->maybe_tree;
- if (commit->graph_pos != COMMIT_NOT_FROM_GRAPH)
+ if (commit_graph_position(commit) != COMMIT_NOT_FROM_GRAPH)
return get_commit_tree_in_graph(r, commit);
return NULL;
@@ -731,9 +731,9 @@ int compare_commits_by_gen_then_commit_date(const void *a_, const void *b_, void
const struct commit *a = a_, *b = b_;
/* newer commits first */
- if (a->generation < b->generation)
+ if (commit_graph_generation(a) < commit_graph_generation(b))
return 1;
- else if (a->generation > b->generation)
+ else if (commit_graph_generation(a) > commit_graph_generation(b))
return -1;
/* use date as a heuristic when generations are equal */