path: root/commit.c
diff options
authorRené Scharfe <>2020-02-09 13:44:23 (GMT)
committerJunio C Hamano <>2020-02-10 17:04:45 (GMT)
commita91cc7fad0d48984135abe2fb70c41db61b500c5 (patch)
treed6b5e82a62a48d7ba436bcaecf1c897ce449161d /commit.c
parentd0654dc308b0ba76dd8ed7bbb33c8d8f7aacd783 (diff)
strbuf: add and use strbuf_insertstr()
Add a function for inserting a C string into a strbuf. Use it throughout the source to get rid of magic string length constants and explicit strlen() calls. Like strbuf_addstr(), implement it as an inline function to avoid the implicit strlen() calls to cause runtime overhead. Helped-by: Taylor Blau <> Helped-by: Eric Sunshine <> Signed-off-by: René Scharfe <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'commit.c')
1 files changed, 1 insertions, 1 deletions
diff --git a/commit.c b/commit.c
index 434ec03..83e1190 100644
--- a/commit.c
+++ b/commit.c
@@ -993,7 +993,7 @@ static int do_sign_commit(struct strbuf *buf, const char *keyid)
strbuf_insert(buf, inspos, gpg_sig_header, gpg_sig_header_len);
inspos += gpg_sig_header_len;
- strbuf_insert(buf, inspos++, " ", 1);
+ strbuf_insertstr(buf, inspos++, " ");
strbuf_insert(buf, inspos, bol, len);
inspos += len;
copypos += len;