diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2019-03-25 12:08:31 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2019-04-01 03:14:50 (GMT) |
| commit | 67a530fab3bbd1d4c3390d6f18e35ab10442c015 (patch) | |
| tree | 12c84108b1715551ddcbeeace65f6f9be78789bf /commit-graph.h | |
| parent | 61df89c8e5559c2b524968f492d445421913bfdb (diff) | |
| download | git-67a530fab3bbd1d4c3390d6f18e35ab10442c015.zip git-67a530fab3bbd1d4c3390d6f18e35ab10442c015.tar.gz git-67a530fab3bbd1d4c3390d6f18e35ab10442c015.tar.bz2 | |
commit-graph: don't pass filename to load_commit_graph_one_fd_st()
An earlier change implemented load_commit_graph_one_fd_st() in a way
that was bug-compatible with earlier code in terms of the "graph file
%s is too small" error message printing out the path to the
commit-graph (".git/objects/info/commit-graph").
But change that, because:
* A function that takes an already-open file descriptor also needing
the filename isn't very intuitive.
* The vast majority of errors we might emit when loading the graph
come from parse_commit_graph(), which doesn't report the
filename. Let's not do that either in this case for consistency.
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'commit-graph.h')
| -rw-r--r-- | commit-graph.h | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/commit-graph.h b/commit-graph.h index 77cc739..ada7aea 100644 --- a/commit-graph.h +++ b/commit-graph.h @@ -53,8 +53,7 @@ struct commit_graph { const unsigned char *chunk_extra_edges; }; -struct commit_graph *load_commit_graph_one_fd_st(const char *graph_file, - int fd, struct stat *st); +struct commit_graph *load_commit_graph_one_fd_st(int fd, struct stat *st); struct commit_graph *parse_commit_graph(void *graph_map, int fd, size_t graph_size); |