summaryrefslogtreecommitdiff
path: root/cache.h
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@osdl.org>2005-09-19 22:53:50 (GMT)
committerJunio C Hamano <junkio@cox.net>2005-09-20 22:07:54 (GMT)
commit2a39064c65e70a3e763c4dff5553cd2af3d10211 (patch)
tree315300157ae438680e1b118eee72e792cc2285d8 /cache.h
parentb0391890d25d9e7ca8f7df2199292df68ead8093 (diff)
downloadgit-2a39064c65e70a3e763c4dff5553cd2af3d10211.zip
git-2a39064c65e70a3e763c4dff5553cd2af3d10211.tar.gz
git-2a39064c65e70a3e763c4dff5553cd2af3d10211.tar.bz2
[PATCH] Return proper error valud from "parse_date()"
Right now we don't return any error value at all from parse_date(), and if we can't parse it, we just silently leave the result buffer unchanged. That's fine for the current user, which will always default to the current date, but it's a crappy interface, and we might well be better off with an error message rather than just the default date. So let's change the thing to return a negative value if an error occurs, and the length of the result otherwise (snprintf behaviour: if the buffer is too small, it returns how big it _would_ have been). [ I started looking at this in case we could support date-based revision names. Looks ugly. Would have to parse relative dates.. ] Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'cache.h')
-rw-r--r--cache.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/cache.h b/cache.h
index 7f20979..e589918 100644
--- a/cache.h
+++ b/cache.h
@@ -242,7 +242,7 @@ extern void *read_object_with_reference(const unsigned char *sha1,
unsigned char *sha1_ret);
const char *show_date(unsigned long time, int timezone);
-void parse_date(const char *date, char *buf, int bufsize);
+int parse_date(const char *date, char *buf, int bufsize);
void datestamp(char *buf, int bufsize);
extern int setup_ident(void);