diff options
| author | Junio C Hamano <gitster@pobox.com> | 2020-03-05 18:43:05 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2020-03-05 18:43:05 (GMT) |
| commit | e63cefb024895fcff4b692cad84cb33ac4c81dcc (patch) | |
| tree | 75658b419b1a097b7bdce369262361323e6c8b7e /builtin | |
| parent | 5da7329e29db93a93099bfee2a81171392341ac8 (diff) | |
| parent | 0106b1d4be166fd4f7bcf0b901d50940c9f539e2 (diff) | |
| download | git-e63cefb024895fcff4b692cad84cb33ac4c81dcc.zip git-e63cefb024895fcff4b692cad84cb33ac4c81dcc.tar.gz git-e63cefb024895fcff4b692cad84cb33ac4c81dcc.tar.bz2 | |
Merge branch 'hi/gpg-use-check-signature'
"git merge signed-tag" while lacking the public key started to say
"No signature", which was utterly wrong. This regression has been
reverted.
* hi/gpg-use-check-signature:
Revert "gpg-interface: prefer check_signature() for GPG verification"
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/fmt-merge-msg.c | 11 |
1 files changed, 4 insertions, 7 deletions
diff --git a/builtin/fmt-merge-msg.c b/builtin/fmt-merge-msg.c index 05a92c5..736f666 100644 --- a/builtin/fmt-merge-msg.c +++ b/builtin/fmt-merge-msg.c @@ -494,7 +494,6 @@ static void fmt_merge_msg_sigs(struct strbuf *out) enum object_type type; unsigned long size, len; char *buf = read_object_file(oid, &type, &size); - struct signature_check sigc = { 0 }; struct strbuf sig = STRBUF_INIT; if (!buf || type != OBJ_TAG) @@ -503,12 +502,10 @@ static void fmt_merge_msg_sigs(struct strbuf *out) if (size == len) ; /* merely annotated */ - else if (!check_signature(buf, len, buf + len, size - len, - &sigc)) { - strbuf_addstr(&sig, sigc.gpg_output); - signature_check_clear(&sigc); - } else - strbuf_addstr(&sig, "gpg verification failed.\n"); + else if (verify_signed_buffer(buf, len, buf + len, size - len, &sig, NULL)) { + if (!sig.len) + strbuf_addstr(&sig, "gpg verification failed.\n"); + } if (!tag_number++) { fmt_tag_signature(&tagbuf, &sig, buf, len); |