path: root/builtin
diff options
authorElijah Newren <>2020-08-18 22:58:25 (GMT)
committerJunio C Hamano <>2020-08-19 00:17:29 (GMT)
commitdad4f23ce59339bb32ad9e1cc1682c696f7a724f (patch)
tree44a55aa6e9c91af202fecd8887a7c175f1db3aa6 /builtin
parent2befe97201e1f3175cce557866c5822793624b5a (diff)
dir: make clear_directory() free all relevant memory
The calling convention for the dir API is supposed to end with a call to clear_directory() to free up no longer needed memory. However, clear_directory() didn't free dir->entries or dir->ignored. I believe this was an oversight, but a number of callers noticed memory leaks and started free'ing these. Unfortunately, they did so somewhat haphazardly (sometimes freeing the entries in the arrays, and sometimes only free'ing the arrays themselves). This suggests the callers weren't trying to make sure any possible memory used might be free'd, but just the memory they noticed their usecase definitely had allocated. Fix this mess by moving all the duplicated free'ing logic into clear_directory(). End by resetting dir to a pristine state so it could be reused if desired. Signed-off-by: Elijah Newren <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin')
2 files changed, 1 insertions, 8 deletions
diff --git a/builtin/clean.c b/builtin/clean.c
index 5a9c29a..4ffe00d 100644
--- a/builtin/clean.c
+++ b/builtin/clean.c
@@ -1021,11 +1021,7 @@ int cmd_clean(int argc, const char **argv, const char *prefix)
string_list_append(&del_list, rel);
- for (i = 0; i <; i++)
- free(dir.entries[i]);
- for (i = 0; i < dir.ignored_nr; i++)
- free(dir.ignored[i]);
+ clear_directory(&dir);
if (interactive && > 0)
diff --git a/builtin/stash.c b/builtin/stash.c
index 10d8763..da48533 100644
--- a/builtin/stash.c
+++ b/builtin/stash.c
@@ -875,11 +875,8 @@ static int get_untracked_files(const struct pathspec *ps, int include_untracked,
strbuf_addstr(untracked_files, ent->name);
/* NUL-terminate: will be fed to update-index -z */
strbuf_addch(untracked_files, '\0');
- free(ent);
- free(dir.entries);
- free(dir.ignored);
return found;