summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorSantiago Torres <santiago@nyu.edu>2016-04-05 16:07:24 (GMT)
committerJunio C Hamano <gitster@pobox.com>2016-04-06 16:02:02 (GMT)
commitd281b45d754477e79a8e0228c8f5ce4195079238 (patch)
tree9b60290b5e62ccff80a7ca0bf51d4d40133996ba /builtin
parent90f7b16b3adc78d4bbabbd426fb69aa78c714f71 (diff)
downloadgit-d281b45d754477e79a8e0228c8f5ce4195079238.zip
git-d281b45d754477e79a8e0228c8f5ce4195079238.tar.gz
git-d281b45d754477e79a8e0228c8f5ce4195079238.tar.bz2
builtin/verify-tag.c: ignore SIGPIPE in gpg-interface
The verify_signed_buffer() function may trigger a SIGPIPE when the GPG child process terminates early (due to a bad keyid, for example) and Git tries to write to it afterwards. Previously, ignoring SIGPIPE was done in builtin/verify-tag.c to avoid this issue. However, any other caller who wants to call verify_signed_buffer() would have to do the same. Use sigchain_push(SIGPIPE, SIG_IGN) in verify_signed_buffer(), pretty much like in sign_buffer(), so that any caller is not required to perform this task. This will avoid possible mistakes by further developers using verify_signed_buffer(). Signed-off-by: Santiago Torres <santiago@nyu.edu> Reviewed-by: Eric Sunshine <sunshine@sunshineco.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/verify-tag.c3
1 files changed, 0 insertions, 3 deletions
diff --git a/builtin/verify-tag.c b/builtin/verify-tag.c
index 00663f6..77f070a 100644
--- a/builtin/verify-tag.c
+++ b/builtin/verify-tag.c
@@ -95,9 +95,6 @@ int cmd_verify_tag(int argc, const char **argv, const char *prefix)
if (verbose)
flags |= GPG_VERIFY_VERBOSE;
- /* sometimes the program was terminated because this signal
- * was received in the process of writing the gpg input: */
- signal(SIGPIPE, SIG_IGN);
while (i < argc)
if (verify_tag(argv[i++], flags))
had_error = 1;