path: root/builtin
diff options
authorRené Scharfe <>2010-10-04 10:53:11 (GMT)
committerJunio C Hamano <>2010-10-06 17:51:14 (GMT)
commitb90d9b889588ca1cfd5667d1fa703d976edd71ee (patch)
treee41d27db561471ca6f95d3630b5c6a23fe4c373a /builtin
parent349362cc207c96bbf31f503db989f0289c13c05d (diff)
work around buggy S_ISxxx(m) implementations
There are buggy implementations of S_ISxxx(m) macros on some platforms (e.g. NetBSD). The issue is that NetBSD doesn't take care to wrap its macro arguments in parentheses, so on Linux and sane systems we have S_ISREG(m) defined as something like: (((m) & S_IFMT) == S_IFREG) But on NetBSD: ((m & _S_IFMT) == _S_IFREG) Since a caller in builtin/diff.c called our macro as `S_IFREG | 0644' this bug introduced a logic error on NetBSD, since the precedence of bit-wise & is higher than | in C. [jc: took change description from Ævar Arnfjörð Bjarmason's patch] Signed-off-by: Rene Scharfe <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions