path: root/builtin
diff options
authorLinus Torvalds <>2012-09-30 22:10:48 (GMT)
committerJunio C Hamano <>2012-10-01 00:29:27 (GMT)
commit9d55b2e12f82b344709b0f2981eaf142b0b1f7a8 (patch)
treef103f1e776fd37be6f6582f5c4a3b96c2e635e93 /builtin
parentd0f1ea6003d97e63110fa7d50bb07f546a909b6e (diff)
mailinfo: don't require "text" mime type for attachments
Currently "git am" does insane things if the mbox it is given contains attachments with a MIME type that aren't "text/*". In particular, it will still decode them, and pass them "one line at a time" to the mail body filter, but because it has determined that they aren't text (without actually looking at the contents, just at the mime type) the "line" will be the encoding line (eg 'base64') rather than a line of *content*. Which then will cause the text filtering to fail, because we won't correctly notice when the attachment text switches from the commit message to the actual patch. Resulting in a patch failure, even if patch may be a perfectly well-formed attachment, it's just that the message type may be (for example) "application/octet-stream" instead of "text/plain". Just remove all the bogus games with the message_type. The only difference that code creates is how the data is passed to the filter function (chunked per-pred-code line or per post-decode line), and that difference is *wrong*, since chunking things per pre-decode line can never be a sensible operation, and cannot possibly matter for binary data anyway. This code goes all the way back to March of 2007, in commit 87ab79923463 ("builtin-mailinfo.c infrastrcture changes"), and apparently Don used to pass random mbox contents to git. However, the pre-decode vs post-decode logic really shouldn't matter even for that case, and more importantly, "I fed git am crap" is not a valid reason to break *real* patch attachments. If somebody really cares, and determines that some attachment is binary data (by looking at the data, not the MIME-type), the whole attachment should be dismissed, rather than fed in random-sized chunks to "handle_filter()". Signed-off-by: Linus Torvalds <> Cc: Don Zickus <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin')
1 files changed, 0 insertions, 11 deletions
diff --git a/builtin/mailinfo.c b/builtin/mailinfo.c
index bfb32b7..2405040 100644
--- a/builtin/mailinfo.c
+++ b/builtin/mailinfo.c
@@ -19,9 +19,6 @@ static struct strbuf email = STRBUF_INIT;
static enum {
} transfer_encoding;
-static enum {
-} message_type;
static struct strbuf charset = STRBUF_INIT;
static int patch_lines;
@@ -185,8 +182,6 @@ static void handle_content_type(struct strbuf *line)
struct strbuf *boundary = xmalloc(sizeof(struct strbuf));
strbuf_init(boundary, line->len);
- if (!strcasestr(line->buf, "text/"))
- message_type = TYPE_OTHER;
if (slurp_attr(line->buf, "boundary=", boundary)) {
strbuf_insert(boundary, 0, "--", 2);
if (++content_top > &content[MAX_BOUNDARIES]) {
@@ -671,7 +666,6 @@ again:
/* set some defaults */
transfer_encoding = TE_DONTCARE;
- message_type = TYPE_TEXT;
/* slurp in this section's info */
while (read_one_header_line(&line, fin))
@@ -885,11 +879,6 @@ static void handle_body(void)
strbuf_insert(&line, 0, prev.buf, prev.len);
- /* binary data most likely doesn't have newlines */
- if (message_type != TYPE_TEXT) {
- handle_filter(&line);
- break;
- }
* This is a decoded line that may contain
* multiple new lines. Pass only one chunk