path: root/builtin
diff options
authorbrian m. carlson <>2021-04-26 01:02:55 (GMT)
committerJunio C Hamano <>2021-04-27 07:31:38 (GMT)
commit5a6dce70d7bb12ee2bc7926254c5b6741b91ac5f (patch)
treea4350b3f781b36cda38fc645a5eb54b161eb4536 /builtin
parent0e5e2284f1267293e56e8948143f6cd04c74e2ed (diff)
hash: set, copy, and use algo field in struct object_id
Now that struct object_id has an algorithm field, we should populate it. This will allow us to handle object IDs in any supported algorithm and distinguish between them. Ensure that the field is written whenever we write an object ID by storing it explicitly every time we write an object. Set values for the empty blob and tree values as well. In addition, use the algorithm field to compare object IDs. Note that because we zero-initialize struct object_id in many places throughout the codebase, we default to the default algorithm in cases where the algorithm field is zero rather than explicitly initialize all of those locations. This leads to a branch on every comparison, but the alternative is to compare the entire buffer each time and padding the buffer for SHA-1. That alternative ranges up to 3.9% worse than this approach on the perf t0001, t1450, and t1451. Signed-off-by: brian m. carlson <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions