summaryrefslogtreecommitdiff
path: root/builtin
diff options
context:
space:
mode:
authorRené Scharfe <l.s.r@web.de>2014-06-06 17:24:48 (GMT)
committerJunio C Hamano <gitster@pobox.com>2014-06-09 21:38:12 (GMT)
commit50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b (patch)
tree37c4a5fad81436a9afc07e87486a26ec8b0b9e9b /builtin
parentbce14aa132e0064d9a9b1c7ad98e71e22c6e0272 (diff)
downloadgit-50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b.zip
git-50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b.tar.gz
git-50e19a83585bd1aeae6aa01d31e5f783b7ef8b1b.tar.bz2
Use starts_with() for C strings instead of memcmp()
Convert three cases of checking for a constant prefix using memcmp() to starts_with(). This way there is no need for magic string length constants and we avoid running over the end of the string should it be shorter than the prefix. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
-rw-r--r--builtin/for-each-ref.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index 3e1d5c3..4135980 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -193,7 +193,7 @@ static int verify_format(const char *format)
at = parse_atom(sp + 2, ep);
cp = ep + 1;
- if (!memcmp(used_atom[at], "color:", 6))
+ if (starts_with(used_atom[at], "color:"))
need_color_reset_at_eol = !!strcmp(used_atom[at], color_reset);
}
return 0;