path: root/builtin
diff options
authorAlexandr Miloslavskiy <>2019-12-16 15:47:52 (GMT)
committerJunio C Hamano <>2019-12-18 22:14:14 (GMT)
commit509efef789de51f5d68e5c9799918f9a5ea09670 (patch)
tree9c56a7d8224c6f2c32e5f8acf7710e614946e2f4 /builtin
parente440fc5888bd5faf1775fc61621caa3c5fab96b6 (diff)
commit: forbid --pathspec-from-file --all
I forgot this in my previous patch `--pathspec-from-file` for `git commit` [1]. When both `--pathspec-from-file` and `--all` were specified, `--all` took precedence and `--pathspec-from-file` was ignored. Before `--pathspec-from-file` was implemented, this case was prevented by this check in `parse_and_validate_options()` : die(_("paths '%s ...' with -a does not make sense"), argv[0]); It is unfortunate that these two cases are disconnected. This came as result of how the code was laid out before my patches, where `pathspec` is parsed outside of `parse_and_validate_options()`. This branch is already full of refactoring patches and I did not dare to go for another one. Fix by mirroring `die()` for `--pathspec-from-file` as well. [1] Commit e440fc58 ("commit: support the --pathspec-from-file option" 2019-11-19) Reported-by: Phillip Wood <> Signed-off-by: Alexandr Miloslavskiy <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin')
1 files changed, 3 insertions, 0 deletions
diff --git a/builtin/commit.c b/builtin/commit.c
index ed40729..c040dc9 100644
--- a/builtin/commit.c
+++ b/builtin/commit.c
@@ -347,6 +347,9 @@ static const char *prepare_index(int argc, const char **argv, const char *prefix
if (interactive)
die(_("--pathspec-from-file is incompatible with --interactive/--patch"));
+ if (all)
+ die(_("--pathspec-from-file with -a does not make sense"));
if (
die(_("--pathspec-from-file is incompatible with pathspec arguments"));