path: root/builtin/verify-pack.c
diff options
authorJeff King <>2014-06-30 16:58:25 (GMT)
committerJunio C Hamano <>2014-06-30 20:43:16 (GMT)
commit2975c770ca609ea5afc80631c4ac9087c527b6fd (patch)
tree54d7b59ce331c9e2079ad730a311347224f76d59 /builtin/verify-pack.c
parentf52a35fd63cc6d570083cedc15576d01c0968d98 (diff)
replace has_extension with ends_with
These two are almost the same function, with the exception that has_extension only matches if there is content before the suffix. So ends_with(".exe", ".exe") is true, but has_extension would not be. This distinction does not matter to any of the callers, though, and we can just replace uses of has_extension with ends_with. We prefer the "ends_with" name because it is more generic, and there is nothing about the function that requires it to be used for file extensions. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/verify-pack.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/verify-pack.c b/builtin/verify-pack.c
index 66cd2df..2fd29ce 100644
--- a/builtin/verify-pack.c
+++ b/builtin/verify-pack.c
@@ -27,9 +27,9 @@ static int verify_one_pack(const char *path, unsigned int flags)
* normalize these forms to "foo.pack" for "index-pack --verify".
strbuf_addstr(&arg, path);
- if (has_extension(arg.buf, ".idx"))
+ if (ends_with(arg.buf, ".idx"))
strbuf_splice(&arg, arg.len - 3, 3, "pack", 4);
- else if (!has_extension(arg.buf, ".pack"))
+ else if (!ends_with(arg.buf, ".pack"))
strbuf_add(&arg, ".pack", 5);
argv[2] = arg.buf;