path: root/builtin/update-ref.c
diff options
authorRonnie Sahlberg <>2014-05-19 17:42:34 (GMT)
committerJunio C Hamano <>2014-09-03 17:04:08 (GMT)
commit93a644ea9d3702cc1cc62c0d413f81f8e46fabe7 (patch)
tree5a979693e1d3c05ced16fde95b012f6d951e496f /builtin/update-ref.c
parent8c8bdc0d3582e42c13815a191344b1aa3e06c792 (diff)
refs.c: make ref_transaction_begin take an err argument
Add an err argument to _begin so that on non-fatal failures in future ref backends we can report a nice error back to the caller. While _begin can currently never fail for other reasons than OOM, in which case we die() anyway, we may add other types of backends in the future. For example, a hypothetical MySQL backend could fail in _begin with "Can not connect to MySQL server. No route to host". Signed-off-by: Ronnie Sahlberg <> Reviewed-by: Michael Haggerty <> Signed-off-by: Jonathan Nieder <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/update-ref.c')
1 files changed, 4 insertions, 1 deletions
diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index 7c9c248..96a53b9 100644
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c
@@ -365,7 +365,9 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
die("Refusing to perform update with empty message.");
if (read_stdin) {
- transaction = ref_transaction_begin();
+ transaction = ref_transaction_begin(&err);
+ if (!transaction)
+ die("%s", err.buf);
if (delete || no_deref || argc > 0)
usage_with_options(git_update_ref_usage, options);
if (end_null)
@@ -374,6 +376,7 @@ int cmd_update_ref(int argc, const char **argv, const char *prefix)
if (ref_transaction_commit(transaction, msg, &err))
die("%s", err.buf);
+ strbuf_release(&err);
return 0;