summaryrefslogtreecommitdiff
path: root/builtin/update-ref.c
diff options
context:
space:
mode:
authorPatrick Steinhardt <ps@pks.im>2020-11-13 08:12:45 (GMT)
committerJunio C Hamano <gitster@pobox.com>2020-11-16 21:44:01 (GMT)
commit8c4417f1cf3c78955a7ea942cc0c8a97e7c77e77 (patch)
tree08794784cbef00a92c0d2189ef4fac24d573a98e /builtin/update-ref.c
parent21020430a4a08d2e31c1c6825e53f194569c706c (diff)
downloadgit-8c4417f1cf3c78955a7ea942cc0c8a97e7c77e77.zip
git-8c4417f1cf3c78955a7ea942cc0c8a97e7c77e77.tar.gz
git-8c4417f1cf3c78955a7ea942cc0c8a97e7c77e77.tar.bz2
update-ref: disallow "start" for ongoing transactions
It is currently possible to write multiple "start" commands into git-update-ref(1) for a single session, but none of them except for the first one actually have any effect. Using such nested "start"s may eventually have a sensible effect. One may imagine that it restarts the current transaction, effectively emptying it and creating a new one. It may also allow for creation of nested transactions. But currently, none of these are implemented. Silently ignoring this misuse is making it hard to iterate in the future if "start" is ever going to have meaningful semantics in such a context. This commit thus makes sure to error out in case we see such use. Signed-off-by: Patrick Steinhardt <ps@pks.im> Reviewed-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/update-ref.c')
-rw-r--r--builtin/update-ref.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/builtin/update-ref.c b/builtin/update-ref.c
index bb65129..6029a80 100644
--- a/builtin/update-ref.c
+++ b/builtin/update-ref.c
@@ -436,6 +436,8 @@ static void update_refs_stdin(void)
switch (state) {
case UPDATE_REFS_OPEN:
case UPDATE_REFS_STARTED:
+ if (state == UPDATE_REFS_STARTED && cmd->state == UPDATE_REFS_STARTED)
+ die("cannot restart ongoing transaction");
/* Do not downgrade a transaction to a non-transaction. */
if (cmd->state >= state)
state = cmd->state;