diff options
| author | Ramkumar Ramachandra <artagnon@gmail.com> | 2013-07-30 08:31:26 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-07-30 15:10:35 (GMT) |
| commit | 7da2f28c6b6f2370254d285c836c6c43a4b8e559 (patch) | |
| tree | 863a0e77ee75199e593c6a0ce4ff8d057c54eb95 /builtin/tar-tree.c | |
| parent | 10d0167fef35c7a4e4e3ef9dd448594b62089c5a (diff) | |
| download | git-7da2f28c6b6f2370254d285c836c6c43a4b8e559.zip git-7da2f28c6b6f2370254d285c836c6c43a4b8e559.tar.gz git-7da2f28c6b6f2370254d285c836c6c43a4b8e559.tar.bz2 | |
tar-tree: remove dependency on sq_quote_print()
By rewriting the loop that formats the argv[] in cmd_tar_tree()
function using sq_quote_argv() for code simplicity, the last use of
sq_quote_print() goes away.
Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/tar-tree.c')
| -rw-r--r-- | builtin/tar-tree.c | 11 |
1 files changed, 5 insertions, 6 deletions
diff --git a/builtin/tar-tree.c b/builtin/tar-tree.c index 3f1e701..ba3ffe6 100644 --- a/builtin/tar-tree.c +++ b/builtin/tar-tree.c @@ -26,8 +26,8 @@ int cmd_tar_tree(int argc, const char **argv, const char *prefix) * $0 tree-ish basedir ==> * git archive --format-tar --prefix=basedir tree-ish */ - int i; const char **nargv = xcalloc(sizeof(*nargv), argc + 3); + struct strbuf sb = STRBUF_INIT; char *basedir_arg; int nargc = 0; @@ -65,11 +65,10 @@ int cmd_tar_tree(int argc, const char **argv, const char *prefix) fprintf(stderr, "*** \"git tar-tree\" is now deprecated.\n" "*** Running \"git archive\" instead.\n***"); - for (i = 0; i < nargc; i++) { - fputc(' ', stderr); - sq_quote_print(stderr, nargv[i]); - } - fputc('\n', stderr); + sq_quote_argv(&sb, nargv, 0); + strbuf_addch(&sb, '\n'); + fputs(sb.buf, stderr); + strbuf_release(&sb); return cmd_archive(nargc, nargv, prefix); } |