summaryrefslogtreecommitdiff
path: root/builtin/tag.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2012-02-06 18:13:27 (GMT)
committerJunio C Hamano <gitster@pobox.com>2012-02-09 04:44:39 (GMT)
commit31fd8d72f2eb82c2b6d8d450ee4e13a3925291c3 (patch)
tree4cee9e7f699ac08f014a4659bd5ae690fdfb3d92 /builtin/tag.c
parentfb630e048c6efabe4d46b1b125fe7348062d38e6 (diff)
downloadgit-31fd8d72f2eb82c2b6d8d450ee4e13a3925291c3.zip
git-31fd8d72f2eb82c2b6d8d450ee4e13a3925291c3.tar.gz
git-31fd8d72f2eb82c2b6d8d450ee4e13a3925291c3.tar.bz2
tag: do not show non-tag contents with "-n"
"git tag -n" did not check the type of the object it is reading the top n lines from. At least, avoid showing the beginning of trees and blobs when dealing with lightweight tags that point at them. As the payload of a tag and a commit look similar in that they both start with a header block, which is skipped for the purpose of "-n" output, followed by human readable text, allow the message of commit objects to be shown just like the contents of tag objects. This avoids regression for people who have been using "tag -n" to show the log messages of commits that are pointed at by lightweight tags. Test script is from Jeff King. Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/tag.c')
-rw-r--r--builtin/tag.c22
1 files changed, 12 insertions, 10 deletions
diff --git a/builtin/tag.c b/builtin/tag.c
index 1e27f5c..6ca53e3 100644
--- a/builtin/tag.c
+++ b/builtin/tag.c
@@ -95,19 +95,20 @@ static void show_tag_lines(const unsigned char *sha1, int lines)
buf = read_sha1_file(sha1, &type, &size);
if (!buf)
die_errno("unable to read object %s", sha1_to_hex(sha1));
- if (!size) {
- free(buf);
- return;
- }
+ if (type != OBJ_COMMIT && type != OBJ_TAG)
+ goto free_return;
+ if (!size)
+ die("an empty %s object %s?",
+ typename(type), sha1_to_hex(sha1));
/* skip header */
sp = strstr(buf, "\n\n");
- if (!sp) {
- free(buf);
- return;
- }
- /* only take up to "lines" lines, and strip the signature */
- size = parse_signature(buf, size);
+ if (!sp)
+ goto free_return;
+
+ /* only take up to "lines" lines, and strip the signature from a tag */
+ if (type == OBJ_TAG)
+ size = parse_signature(buf, size);
for (i = 0, sp += 2; i < lines && sp < buf + size; i++) {
if (i)
printf("\n ");
@@ -118,6 +119,7 @@ static void show_tag_lines(const unsigned char *sha1, int lines)
break;
sp = eol + 1;
}
+free_return:
free(buf);
}