path: root/builtin/show-branch.c
diff options
authorJeff King <>2014-07-24 04:41:11 (GMT)
committerJunio C Hamano <>2014-07-24 20:57:49 (GMT)
commit28b3563241ac13733781fb0bada37f776a39f43d (patch)
treecd78612af838e155c552b5ea5a10fe691e627e6d /builtin/show-branch.c
parentd51428bf17e9f17071836350299e256cac2d503a (diff)
free ref string returned by dwim_ref
A call to "dwim_ref(name, len, flags, &ref)" will allocate a new string in "ref" to return the exact ref we found. We do not consistently free it in all code paths, leading to small leaks. The worst is in get_sha1_basic, which may be called many times (e.g., by "cat-file --batch"), though it is relatively unlikely, as it only triggers on a bogus reflog specification. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/show-branch.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/show-branch.c b/builtin/show-branch.c
index d873172..b293090 100644
--- a/builtin/show-branch.c
+++ b/builtin/show-branch.c
@@ -779,6 +779,7 @@ int cmd_show_branch(int ac, const char **av, const char *prefix)
sprintf(nth_desc, "%s@{%d}", *av, base+i);
append_ref(nth_desc, sha1, 1);
+ free(ref);
else if (all_heads + all_remotes)
snarf_refs(all_heads, all_remotes);