summaryrefslogtreecommitdiff
path: root/builtin/shortlog.c
diff options
context:
space:
mode:
authorStephen Boyd <bebarino@gmail.com>2010-12-06 07:57:42 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-12-07 00:51:36 (GMT)
commit9ca1169fd92c71ebbef92ff18aa5d91a2157d1bd (patch)
treea1490182bae47da917a1d64a3ce1a52dbece0425 /builtin/shortlog.c
parent16529f2e5630d3d155e4dff0ebd3c7c5daa882f9 (diff)
downloadgit-9ca1169fd92c71ebbef92ff18aa5d91a2157d1bd.zip
git-9ca1169fd92c71ebbef92ff18aa5d91a2157d1bd.tar.gz
git-9ca1169fd92c71ebbef92ff18aa5d91a2157d1bd.tar.bz2
parse-options: Don't call parse_options_check() so much
parse_options_check() is being called for each invocation of parse_options_step which can be quite a bit for some commands. The commit introducing this function cb9d398 (parse-options: add parse_options_check to validate option specs., 2009-06-09) had the correct motivation and explicitly states that parse_options_check() should be called from parse_options_start(). However, the implementation differs from the motivation. Fix it. Signed-off-by: Stephen Boyd <bebarino@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/shortlog.c')
-rw-r--r--builtin/shortlog.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/shortlog.c b/builtin/shortlog.c
index 2135b0d..1a21e4b 100644
--- a/builtin/shortlog.c
+++ b/builtin/shortlog.c
@@ -268,8 +268,8 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix)
git_config(git_default_config, NULL);
shortlog_init(&log);
init_revisions(&rev, prefix);
- parse_options_start(&ctx, argc, argv, prefix, PARSE_OPT_KEEP_DASHDASH |
- PARSE_OPT_KEEP_ARGV0);
+ parse_options_start(&ctx, argc, argv, prefix, options,
+ PARSE_OPT_KEEP_DASHDASH | PARSE_OPT_KEEP_ARGV0);
for (;;) {
switch (parse_options_step(&ctx, options, shortlog_usage)) {