diff options
| author | Nguyễn Thái Ngọc Duy <pclouds@gmail.com> | 2018-12-11 15:35:01 (GMT) |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2018-12-12 08:21:33 (GMT) |
| commit | a92ec7efe0ad25f1c2047230c0324dcb54ce1cfc (patch) | |
| tree | 0089c72cfbdf54da76582fc210048badce72071e /builtin/shortlog.c | |
| parent | 6da2d9595161441cbed1b1f579b8dd46970a8e20 (diff) | |
| download | git-a92ec7efe0ad25f1c2047230c0324dcb54ce1cfc.zip git-a92ec7efe0ad25f1c2047230c0324dcb54ce1cfc.tar.gz git-a92ec7efe0ad25f1c2047230c0324dcb54ce1cfc.tar.bz2 | |
parse-options: fix SunCC compiler warning
The compiler reports this because show_gitcomp() never actually
returns a value:
"parse-options.c", line 520: warning: Function has no return
statement : show_gitcomp
We could shut the compiler up. But instead let's not bury exit() too
deep. Do the same as internal -h handling, return a special error code
and handle the exit() in parse_options() (and other
parse_options_step() callers) instead.
Reported-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/shortlog.c')
| -rw-r--r-- | builtin/shortlog.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/builtin/shortlog.c b/builtin/shortlog.c index 608d6ba..e9c12bd 100644 --- a/builtin/shortlog.c +++ b/builtin/shortlog.c @@ -286,6 +286,8 @@ int cmd_shortlog(int argc, const char **argv, const char *prefix) case PARSE_OPT_HELP: case PARSE_OPT_ERROR: exit(129); + case PARSE_OPT_COMPLETE: + exit(0); case PARSE_OPT_DONE: goto parse_done; } |