path: root/builtin/rev-parse.c
diff options
authorJeff King <>2019-11-19 08:05:43 (GMT)
committerJunio C Hamano <>2019-11-20 01:19:58 (GMT)
commit2d92ab32fd624349d308334befbf07adf9f179b9 (patch)
tree03c48980c4a44bb537b12b3736334eb83b276bd8 /builtin/rev-parse.c
parentd9f6f3b6195a0ca35642561e530798ad1469bd41 (diff)
rev-parse: make --show-toplevel without a worktree an error
Ever since it was introduced in 7cceca5ccc (Add 'git rev-parse --show-toplevel' option., 2010-01-12), the --show-toplevel option has treated a missing working tree as a quiet success: it neither prints a toplevel path, but nor does it report any kind of error. While a caller could distinguish this case by looking for an empty response, the behavior is rather confusing. We're better off complaining that there is no working tree, as other internal commands would do in similar cases (e.g., "git status" or any builtin with NEED_WORK_TREE set would just die()). So let's do the same here. While we're at it, let's clarify the documentation and add some tests, both for the new behavior and for the more mundane case (which was not covered). Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/rev-parse.c')
1 files changed, 2 insertions, 0 deletions
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c
index 85ce209..7a00da8 100644
--- a/builtin/rev-parse.c
+++ b/builtin/rev-parse.c
@@ -803,6 +803,8 @@ int cmd_rev_parse(int argc, const char **argv, const char *prefix)
const char *work_tree = get_git_work_tree();
if (work_tree)
+ else
+ die("this operation must be run in a work tree");
if (!strcmp(arg, "--show-superproject-working-tree")) {