summaryrefslogtreecommitdiff
path: root/builtin/rev-list.c
diff options
context:
space:
mode:
authorJeff King <peff@peff.net>2015-08-23 17:56:40 (GMT)
committerJunio C Hamano <gitster@pobox.com>2015-08-24 17:33:15 (GMT)
commit2aea7a51a11598427d5b57e4bc042930d592547f (patch)
tree51f04bb0b1edd9ae55407627736b7ee9dfa1510c /builtin/rev-list.c
parent552a736de775994570570a0514f24e32686afbe0 (diff)
downloadgit-2aea7a51a11598427d5b57e4bc042930d592547f.zip
git-2aea7a51a11598427d5b57e4bc042930d592547f.tar.gz
git-2aea7a51a11598427d5b57e4bc042930d592547f.tar.bz2
rev-list: make it obvious that we do not support notes
The rev-list command does not have the internal infrastructure to display notes. Running: git rev-list --notes HEAD will silently ignore the "--notes" option. Running: git rev-list --notes --grep=. HEAD will crash on an assert. Running: git rev-list --format=%N HEAD will place a literal "%N" in the output (it does not even expand to an empty string). Let's have rev-list tell the user that it cannot fill the user's request, rather than silently producing wrong data. Likewise, let's remove mention of the notes options from the rev-list documentation. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rev-list.c')
-rw-r--r--builtin/rev-list.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/builtin/rev-list.c b/builtin/rev-list.c
index c0b4b53..d80d1ed 100644
--- a/builtin/rev-list.c
+++ b/builtin/rev-list.c
@@ -350,6 +350,9 @@ int cmd_rev_list(int argc, const char **argv, const char *prefix)
revs.diff)
usage(rev_list_usage);
+ if (revs.show_notes)
+ die(_("rev-list does not support display of notes"));
+
save_commit_buffer = (revs.verbose_header ||
revs.grep_filter.pattern_list ||
revs.grep_filter.header_list);