path: root/builtin/receive-pack.c
diff options
authorJeff King <>2018-10-08 18:09:23 (GMT)
committerJunio C Hamano <>2018-10-09 05:30:02 (GMT)
commitbdf4276c91623cf57efefd2ada7fb3e0709e2230 (patch)
tree4fb58324836e7517b40e3d9612d6c1ceb72ef208 /builtin/receive-pack.c
parentcae598d9980661a978e2df4fb338518f7bf09572 (diff)
transport: drop refnames from for_each_alternate_ref
None of the current callers use the refname parameter we pass to their callbacks. In theory somebody _could_ do so, but it's actually quite weird if you think about it: it's a ref in somebody else's repository. So the name has no meaning locally, and in fact there may be duplicates if there are multiple alternates. The users of this interface really only care about seeing some ref tips, since that promises that the alternate has the full commit graph reachable from there. So let's keep the information we pass back to the bare minimum. Signed-off-by: Jeff King <> Signed-off-by: Taylor Blau <> Acked-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/receive-pack.c')
1 files changed, 1 insertions, 2 deletions
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index c17ce94..edbc76f 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -280,8 +280,7 @@ static int show_ref_cb(const char *path_full, const struct object_id *oid,
return 0;
-static void show_one_alternate_ref(const char *refname,
- const struct object_id *oid,
+static void show_one_alternate_ref(const struct object_id *oid,
void *data)
struct oidset *seen = data;