path: root/builtin/receive-pack.c
diff options
authorLars Schneider <>2016-10-16 23:20:29 (GMT)
committerJunio C Hamano <>2016-10-17 18:36:50 (GMT)
commit81c634e94f2fef0cec295f7554080c82bd6aeeb7 (patch)
treeee53d4aa768f496f3f34f9945e0ff3266340d14d /builtin/receive-pack.c
parentac2fbaa674ce3d5b5faf6a83f88cc4af1654f9cd (diff)
pkt-line: rename packet_write() to packet_write_fmt()
packet_write() should be called packet_write_fmt() because it is a printf-like function that takes a format string as first parameter. packet_write_fmt() should be used for text strings only. Arbitrary binary data should use a new packet_write() function that is introduced in a subsequent patch. Suggested-by: Junio C Hamano <> Signed-off-by: Lars Schneider <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/receive-pack.c')
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin/receive-pack.c b/builtin/receive-pack.c
index f1ce05c..173d081 100644
--- a/builtin/receive-pack.c
+++ b/builtin/receive-pack.c
@@ -224,7 +224,7 @@ static int receive_pack_config(const char *var, const char *value, void *cb)
static void show_ref(const char *path, const unsigned char *sha1)
if (sent_capabilities) {
- packet_write(1, "%s %s\n", sha1_to_hex(sha1), path);
+ packet_write_fmt(1, "%s %s\n", sha1_to_hex(sha1), path);
} else {
struct strbuf cap = STRBUF_INIT;
@@ -239,7 +239,7 @@ static void show_ref(const char *path, const unsigned char *sha1)
if (advertise_push_options)
strbuf_addstr(&cap, " push-options");
strbuf_addf(&cap, " agent=%s", git_user_agent_sanitized());
- packet_write(1, "%s %s%c%s\n",
+ packet_write_fmt(1, "%s %s%c%s\n",
sha1_to_hex(sha1), path, 0, cap.buf);
sent_capabilities = 1;