path: root/builtin/pack-objects.c
diff options
authorJeff King <>2014-10-17 01:11:43 (GMT)
committerJunio C Hamano <>2014-10-19 22:08:38 (GMT)
commit21134714787a02a37da15424d72c0119b2b8ed71 (patch)
treeae02ffed1ca43594b4dcc4a66ddff7f3f24146f3 /builtin/pack-objects.c
parent76f8611a5fb7e81c1bada0fb190d573a66fc03f6 (diff)
pack-objects: turn off bitmaps when we split packs
If a pack.packSizeLimit is set, we may split the pack data across multiple packfiles. This means we cannot generate .bitmap files, as they require that all of the reachable objects are in the same pack. We check that condition when we are generating the list of objects to pack (and disable bitmaps if we are not packing everything), but we forgot to update it when we notice that we needed to split (which doesn't happen until the actual write phase). The resulting bitmaps are quite bogus (they mention entries that do not exist in the pack!) and can cause a fetch or push to send insufficient objects. Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/pack-objects.c')
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
index de36c60..a6c91fa 100644
--- a/builtin/pack-objects.c
+++ b/builtin/pack-objects.c
@@ -812,6 +812,7 @@ static void write_pack_file(void)
fixup_pack_header_footer(fd, sha1, pack_tmp_name,
nr_written, sha1, offset);
+ write_bitmap_index = 0;
if (!pack_to_stdout) {