summaryrefslogtreecommitdiff
path: root/builtin/mv.c
diff options
context:
space:
mode:
authorBrandon Casey <drafnel@gmail.com>2011-10-06 18:22:21 (GMT)
committerJunio C Hamano <gitster@pobox.com>2011-10-06 20:54:31 (GMT)
commit97410b27e91593c4096bb16abbace783895a1f62 (patch)
tree4dcdd6e582aed512c291be7a1b13dd68bc6a3098 /builtin/mv.c
parent5738c9c21e53356ab5020912116e7f82fd2d428f (diff)
downloadgit-97410b27e91593c4096bb16abbace783895a1f62.zip
git-97410b27e91593c4096bb16abbace783895a1f62.tar.gz
git-97410b27e91593c4096bb16abbace783895a1f62.tar.bz2
attr.c: avoid inappropriate access to strbuf "buf" member
This code sequence performs a strcpy into the buf member of a strbuf struct. The strcpy may move the position of the terminating nul of the string and effectively change the length of string so that it does not match the len member of the strbuf struct. Currently, this sequence works since the strbuf was given a hint when it was initialized to allocate enough space to accomodate the string that will be strcpy'ed, but this is an implementation detail of strbufs, not a guarantee. So, lets rework this sequence so that the strbuf is only manipulated by strbuf functions, and direct modification of its "buf" member is not necessary. Signed-off-by: Brandon Casey <drafnel@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/mv.c')
0 files changed, 0 insertions, 0 deletions