summaryrefslogtreecommitdiff
path: root/builtin/merge.c
diff options
context:
space:
mode:
authorTay Ray Chuan <rctay89@gmail.com>2010-05-10 17:17:52 (GMT)
committerJunio C Hamano <gitster@pobox.com>2010-05-10 19:02:20 (GMT)
commitf0ecac2b70bf6b44b89dfa493abd2f544010b1eb (patch)
tree2fd6c98705ae583f32b25d9ee36567e5a2554b65 /builtin/merge.c
parent8c6bdfdf8ba9a3d7a03d64b7a98305a460921130 (diff)
downloadgit-f0ecac2b70bf6b44b89dfa493abd2f544010b1eb.zip
git-f0ecac2b70bf6b44b89dfa493abd2f544010b1eb.tar.gz
git-f0ecac2b70bf6b44b89dfa493abd2f544010b1eb.tar.bz2
merge: --log appends shortlog to message if specified
When the user specifies a message, use fmt_merge_msg_shortlog() to append the shortlog. Previously, when a message was specified, we ignored the merge title ("Merge <foo> into <bar>") and shortlog from fmt_merge_msg(). Update the documentation for -m to reflect this too. Signed-off-by: Tay Ray Chuan <rctay89@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/merge.c')
-rw-r--r--builtin/merge.c18
1 files changed, 11 insertions, 7 deletions
diff --git a/builtin/merge.c b/builtin/merge.c
index 0ae4809..cae1cbe 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -981,18 +981,22 @@ int cmd_merge(int argc, const char **argv, const char *prefix)
/*
* All the rest are the commits being merged;
* prepare the standard merge summary message to
- * used as the merge message. If remote
+ * be appended to the given message. If remote
* is invalid we will die later in the common
* codepath so we discard the error in this
* loop.
*/
- if (!have_message) {
- for (i = 0; i < argc; i++)
- merge_name(argv[i], &merge_names);
+ for (i = 0; i < argc; i++)
+ merge_name(argv[i], &merge_names);
+
+ if (have_message && option_log)
+ fmt_merge_msg_shortlog(&merge_names, &merge_msg);
+ else if (!have_message)
fmt_merge_msg(option_log, &merge_names, &merge_msg);
- if (merge_msg.len)
- strbuf_setlen(&merge_msg, merge_msg.len-1);
- }
+
+
+ if (!(have_message && !option_log) && merge_msg.len)
+ strbuf_setlen(&merge_msg, merge_msg.len-1);
}
if (head_invalid || !argc)