path: root/builtin/merge.c
diff options
authorJunio C Hamano <>2015-04-16 15:03:14 (GMT)
committerJunio C Hamano <>2015-04-16 15:03:14 (GMT)
commit3d6bc9a763f56156b424e7382b4029a67a49847e (patch)
treea4cde8ea79d82c70e7685858cbdd3c054272231e /builtin/merge.c
parente46fe3df01435bf523d2ab4f2755556c0e4e6f78 (diff)
Revert "merge: pass verbosity flag down to merge-recursive"
This reverts commit 2bf15a3330a26183adc8563dbeeacc11294b8a01, whose intention was good, but the verbosity levels used in merge-recursive turns out to be rather uneven. For example, a merge of two branches with conflicting submodule updates used to report CONFLICT: output with --quiet but no longer (which *is* desired), while the final "Automatic merge failed; fix conflicts and then commit" message is still shown even with --quiet (which *is* inconsistent). Originally reported by Bryan Turner; it is too early to declare what the concensus is, but it seems that we would need to level the verbosity levels used in merge strategy backends before we can go forward. In the meantime, we'd revert to the old behaviour until that happens. cf. $gmane/267245
Diffstat (limited to 'builtin/merge.c')
1 files changed, 0 insertions, 4 deletions
diff --git a/builtin/merge.c b/builtin/merge.c
index 068a83b..3b0f8f9 100644
--- a/builtin/merge.c
+++ b/builtin/merge.c
@@ -684,10 +684,6 @@ static int try_merge_strategy(const char *strategy, struct commit_list *common,
o.subtree_shift = "";
o.renormalize = option_renormalize;
- if (verbosity < 0)
- o.verbosity = verbosity;
- else if (verbosity > 0)
- o.verbosity += verbosity;
o.show_rename_progress =
show_progress == -1 ? isatty(2) : show_progress;