path: root/builtin/ls-remote.c
diff options
authorJeff King <>2018-10-31 04:24:05 (GMT)
committerJunio C Hamano <>2018-10-31 04:40:09 (GMT)
commit631f0f8c4b3cf86df13534be40b8df56c2fc6dda (patch)
tree99d1dd012fb27759960586475fa3013ff6023f5c /builtin/ls-remote.c
parent268fbcd172cdb306e8a3e7143cc16677c963d6cd (diff)
ls-remote: do not send ref prefixes for patterns
Since b4be74105f (ls-remote: pass ref prefixes when requesting a remote's refs, 2018-03-15), "ls-remote foo" will pass "refs/heads/foo", "refs/tags/foo", etc to the transport code in an attempt to let the other side reduce the size of its advertisement. Unfortunately this is not correct, as ls-remote patterns do not follow the usual ref lookup rules, and are in fact tail-matched. So we could find "refs/heads/foo" or "refs/heads/a/much/deeper/foo" or even "refs/another/hierarchy/foo". Since we can't pass a prefix and there's not yet a v2 extension for matching wildcards, we must disable this feature to keep the same behavior as v1. Reported-by: Jon Simons <> Signed-off-by: Jeff King <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/ls-remote.c')
1 files changed, 0 insertions, 8 deletions
diff --git a/builtin/ls-remote.c b/builtin/ls-remote.c
index 1a25df7..dee9dd8 100644
--- a/builtin/ls-remote.c
+++ b/builtin/ls-remote.c
@@ -88,15 +88,7 @@ int cmd_ls_remote(int argc, const char **argv, const char *prefix)
int i;
pattern = xcalloc(argc, sizeof(const char *));
for (i = 1; i < argc; i++) {
- const char *glob;
pattern[i - 1] = xstrfmt("*/%s", argv[i]);
- glob = strchr(argv[i], '*');
- if (glob)
- argv_array_pushf(&ref_prefixes, "%.*s",
- (int)(glob - argv[i]), argv[i]);
- else
- expand_ref_prefix(&ref_prefixes, argv[i]);