path: root/builtin/log.c
diff options
authorStefan Beller <>2018-12-15 00:09:40 (GMT)
committerJunio C Hamano <>2018-12-28 18:06:33 (GMT)
commit6a7895fd8a3bd409f2b71ffc355d5142172cc2a0 (patch)
treefc7736800e138da6506f50485fb246615dde0ad5 /builtin/log.c
parent4f542b7a7f944986e3f7567f7e94b256b1929f6c (diff)
commit: prepare free_commit_buffer and release_commit_memory for any repo
Pass the object pool to free_commit_buffer and release_commit_memory, such that we can eliminate access to 'the_repository'. Also remove the TODO in release_commit_memory, as commit->util was removed in 9d2c97016f (commit.h: delete 'util' field in struct commit, 2018-05-19) Signed-off-by: Stefan Beller <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/log.c')
1 files changed, 4 insertions, 2 deletions
diff --git a/builtin/log.c b/builtin/log.c
index 061d4fd..64c2649 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -395,7 +395,8 @@ static int cmd_log_walk(struct rev_info *rev)
* We may show a given commit multiple times when
* walking the reflogs.
- free_commit_buffer(commit);
+ free_commit_buffer(the_repository->parsed_objects,
+ commit);
commit->parents = NULL;
@@ -1922,7 +1923,8 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix)
open_next_file(rev.numbered_files ? NULL : commit, NULL, &rev, quiet))
die(_("Failed to create output files"));
shown = log_tree_commit(&rev, commit);
- free_commit_buffer(commit);
+ free_commit_buffer(the_repository->parsed_objects,
+ commit);
/* We put one extra blank line between formatted
* patches and this flag is used by log-tree code