path: root/builtin/help.c
diff options
authorJohannes Schindelin <>2016-08-19 08:39:38 (GMT)
committerJunio C Hamano <>2016-08-19 20:47:28 (GMT)
commit6db5967d4e6640c5a3ee3cde151c5fdde5ab508f (patch)
tree4104e0be2ac634cb0c47472658184f1d5f0632dd /builtin/help.c
parent0b65a8dbdb38962e700ee16776a3042beb489060 (diff)
Revert "display HTML in default browser using Windows' shell API"
Since 4804aab (help (Windows): Display HTML in default browser using Windows' shell API, 2008-07-13), Git for Windows used to call `ShellExecute()` to launch the default Windows handler for `.html` files. The idea was to avoid going through a shell script, for performance reasons. However, this change ignores the `help.browser` config setting. Together with browsing help not being a performance-critical operation, let's just revert that patch. Signed-off-by: Johannes Schindelin <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/help.c')
1 files changed, 0 insertions, 7 deletions
diff --git a/builtin/help.c b/builtin/help.c
index 3c55ce4..0c91ff5 100644
--- a/builtin/help.c
+++ b/builtin/help.c
@@ -379,17 +379,10 @@ static void get_html_page_path(struct strbuf *page_path, const char *page)
- * If open_html is not defined in a platform-specific way (see for
- * example compat/mingw.h), we use the script web--browse to display
- * HTML.
- */
-#ifndef open_html
static void open_html(const char *path)
execl_git_cmd("web--browse", "-c", "help.browser", path, (char *)NULL);
static void show_html_page(const char *git_cmd)