path: root/builtin/grep.c
diff options
authorBrandon Williams <>2017-03-17 17:22:57 (GMT)
committerJunio C Hamano <>2017-03-17 18:54:50 (GMT)
commitb2dfeb7c005b83145e9f61305658f5dac745482a (patch)
tree74f4b5cbf216eabb38041d6e53fa61a231c07ebf /builtin/grep.c
parente4770f67d16c1970fa175bddfd4ca40258e57f22 (diff)
ls-files: fix bug when recursing with relative pathspec
When using the --recurse-submodules flag with a relative pathspec which includes "..", an error is produced inside the child process spawned for a submodule. When creating the pathspec struct in the child, the ".." is interpreted to mean "go up a directory" which causes an error stating that the path ".." is outside of the repository. While it is true that ".." is outside the scope of the submodule, it is confusing to a user who originally invoked the command where ".." was indeed still inside the scope of the superproject. Since the child process launched for the submodule has some context that it is operating underneath a superproject, this error could be avoided. This patch fixes the bug by passing the 'prefix' to the child process. Now each child process that works on a submodule has two points of reference to the superproject: (1) the 'super_prefix' which is the path from the root of the superproject down to root of the submodule and (2) the 'prefix' which is the path from the root of the superproject down to the directory where the user invoked the git command. With these two pieces of information a child process can correctly interpret the pathspecs provided by the user as well as being able to properly format its output relative to the directory the user invoked the original command from. Signed-off-by: Brandon Williams <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/grep.c')
0 files changed, 0 insertions, 0 deletions