path: root/builtin/gc.c
diff options
authorÆvar Arnfjörð Bjarmason <>2019-03-13 23:54:35 (GMT)
committerJunio C Hamano <>2019-03-14 04:55:28 (GMT)
commit8bf14444c3989aa0f5b01ba67dfb4b592e6c30d3 (patch)
tree96a015aa2d312ea9e31cd12d6b9649bab54e0d51 /builtin/gc.c
parente902e9bcae2010bc42648c80ab6adc6c5a16a4a5 (diff)
gc: remove redundant check for gc_auto_threshold
Checking gc_auto_threshold in too_many_loose_objects() was added in 17815501a8 ("git-gc --auto: run "repack -A -d -l" as necessary.", 2007-09-17) when need_to_gc() itself was also reliant on gc_auto_pack_limit before its early return: gc_auto_threshold <= 0 && gc_auto_pack_limit <= 0 When that check was simplified to just checking "gc_auto_threshold <= 0" in b14d255ba8 ("builtin-gc.c: allow disabling all auto-gc'ing by assigning 0 to", 2008-03-19) this unreachable code should have been removed. We only call too_many_loose_objects() from within need_to_gc() itself, which will return if this condition holds, and in cmd_gc() which will return before ever getting to "auto_gc && too_many_loose_objects()" if "auto_gc && !need_to_gc()" is true earlier in the function. Signed-off-by: Ævar Arnfjörð Bjarmason <> Signed-off-by: Junio C Hamano <>
Diffstat (limited to 'builtin/gc.c')
1 files changed, 0 insertions, 3 deletions
diff --git a/builtin/gc.c b/builtin/gc.c
index 020f725..8c23126 100644
--- a/builtin/gc.c
+++ b/builtin/gc.c
@@ -157,9 +157,6 @@ static int too_many_loose_objects(void)
int num_loose = 0;
int needed = 0;
- if (gc_auto_threshold <= 0)
- return 0;
dir = opendir(git_path("objects/17"));
if (!dir)
return 0;