summaryrefslogtreecommitdiff
path: root/builtin/fsck.c
diff options
context:
space:
mode:
authorMichael Haggerty <mhagger@alum.mit.edu>2013-05-25 09:08:11 (GMT)
committerJunio C Hamano <gitster@pobox.com>2013-05-28 16:25:01 (GMT)
commit16aa3bfc9b9dc587d02f29d8e54810480cf955e4 (patch)
tree2d78148a37b435ee6a6b5795d70777e6498d708c /builtin/fsck.c
parent1506510c170d23b8f769757dc81904f334c40281 (diff)
downloadgit-16aa3bfc9b9dc587d02f29d8e54810480cf955e4.zip
git-16aa3bfc9b9dc587d02f29d8e54810480cf955e4.tar.gz
git-16aa3bfc9b9dc587d02f29d8e54810480cf955e4.tar.bz2
fsck: don't put a void*-shaped peg in a char*-shaped hole
The source of this nonsense was 04d3975937 fsck: reduce stack footprint , which wedged a pointer to parent into the object_array_entry's name field. The parent pointer was passed to traverse_one_object(), even though that function *didn't use it*. The useless code has been deleted over time. Commit a1cdc25172 fsck: drop unused parameter from traverse_one_object() removed the parent pointer from traverse_one_object()'s signature. Commit c0aa335c95 Remove unused variables removed the code that read the parent pointer back out of the name field. This commit takes the last step: don't write the parent pointer into the name field in the first place. Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/fsck.c')
-rw-r--r--builtin/fsck.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/fsck.c b/builtin/fsck.c
index bb9a2cd..9909b6d 100644
--- a/builtin/fsck.c
+++ b/builtin/fsck.c
@@ -112,7 +112,7 @@ static int mark_object(struct object *obj, int type, void *data)
return 1;
}
- add_object_array(obj, (void *) parent, &pending);
+ add_object_array(obj, NULL, &pending);
return 0;
}