summaryrefslogtreecommitdiff
path: root/builtin/for-each-ref.c
diff options
context:
space:
mode:
authorKacper Kornet <draenog@pld-linux.org>2012-08-21 07:47:26 (GMT)
committerJunio C Hamano <gitster@pobox.com>2012-08-21 21:42:12 (GMT)
commit3b51222ceceed022f45193db19c57cf53f0164df (patch)
treee68d79593a8252f033cf5d0ca527a6a9228cf6fb /builtin/for-each-ref.c
parent912072d53a6f257fbbfd8a103e14248ae2382b6d (diff)
downloadgit-3b51222ceceed022f45193db19c57cf53f0164df.zip
git-3b51222ceceed022f45193db19c57cf53f0164df.tar.gz
git-3b51222ceceed022f45193db19c57cf53f0164df.tar.bz2
for-each-ref: Fix sort with multiple keys
The linked list describing sort options was not correctly set up in opt_parse_sort. In the result, contrary to the documentation, only the last of multiple --sort options to git-for-each-ref was taken into account. This commit fixes it. Signed-off-by: Kacper Kornet <draenog@pld-linux.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/for-each-ref.c')
-rw-r--r--builtin/for-each-ref.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin/for-each-ref.c b/builtin/for-each-ref.c
index b01d76a..0c5294e 100644
--- a/builtin/for-each-ref.c
+++ b/builtin/for-each-ref.c
@@ -962,7 +962,9 @@ static int opt_parse_sort(const struct option *opt, const char *arg, int unset)
if (!arg) /* should --no-sort void the list ? */
return -1;
- *sort_tail = s = xcalloc(1, sizeof(*s));
+ s = xcalloc(1, sizeof(*s));
+ s->next = *sort_tail;
+ *sort_tail = s;
if (*arg == '-') {
s->reverse = 1;